akulubala / vue-product-zoomer

Zoom Prodct Image, useful for e-shop website
http://www.yoohooworld.com/demo.html
MIT License
290 stars 69 forks source link

Font Awesome render as <i> not <svg> #13

Closed luhegi closed 6 years ago

luhegi commented 6 years ago

can you help me with this issue? it working correctly but the icon not rendering as svg but as <i aria-hidden="true" class="fa fa-angle-right"></i>

akulubala commented 6 years ago

it should be SVG, which version and browser you are using?

luhegi commented 6 years ago

i'm using "version": "2.0.11"

akulubala commented 6 years ago

version 2.0.11 using fontawsome 5, it should be an SVG file, maybe you should check if your package installed correctly, can't help you without more details.

luhegi commented 6 years ago

i'm using fontawesome 5, can i use fontawesome 5 for vue-product-zommer too?

akulubala commented 6 years ago

@luhegi, I was wrong with the version, it's using fontawesome 5, can't help you if you can't provide more details.

luhegi commented 6 years ago

i'm using https://github.com/cretueusebiu/laravel-vue-spa, he using font awesome 5 in resources/assets/js/plugins/fontawesome.js

akulubala commented 6 years ago

@luhegi I've been checked again with larave-vue-spa, there was no issue for using this plugin, please make sure you are using it correctly. This issue should be closed now since it's not this plugins problem.

luhegi commented 6 years ago

ok, thanks for checking. i'll try to fix it