akumaigorodski / wallet

Bitcoin wallet for Android
https://sbw.app
Apache License 2.0
240 stars 73 forks source link

Can't edit inbound lightning payment #99

Closed 12nick12 closed 3 years ago

12nick12 commented 3 years ago

I created an inbound request, but am unable to edit to delete it since I'm actully not going to send money to it. I'm running CalyxOS on a Pixel 4a 5G.

12nick12 commented 3 years ago

When I hit edit nothing happens. It shows the animation like it was hit, but nothing pops up.

12nick12 commented 3 years ago

I did notice when I'm on the main page I can swipe to the right and delete it that way.

akumaigorodski commented 3 years ago

There's indeed no way to edit an already created LN payment since that will have implications for its invoice.

What can be done is creating a new one (and old one can be deleted). Does this resolve the issue?

12nick12 commented 3 years ago

That's what I ended up doing. Just confusing since there's an edit option.

Oct 23, 2021 1:51:02 AM Anton Kumaigorodski @.***>:

There's indeed no way to edit an already created LN payment since that will have implications for its invoice.

What can be done is creating a new one (and old one can be deleted). Does this resolve the issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[https://github.com/btcontract/wallet/issues/99#issuecomment-950091616], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AEH2ARNUOKZ7GSLW5GMAPWDUIJEMJANCNFSM5GRURMYA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AEH2ARM3IS5LN4UPGBRNOF3UIJEMJA5CNFSM5GRURMYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHCQT6YA.gif]

akumaigorodski commented 3 years ago

Ah, I see, you probably mean a "pencil" edit under the QR code. That's a minor bug, it should not be there and it's been fixed in update 2.2.15.1.