search

akvelon / react-native-sms-user-consent

React Native wrapper for Android's SMS User Consent API, ready to use in React Native apps with minimum effort.
Other
89 stars 40 forks source link

Google Play will reject my app for Intent Redirection Vulnerability #5

Closed LightKnight3r closed 3 years ago

LightKnight3r commented 3 years ago

I got a notification from google like that:

Screen Shot 2021-08-06 at 11 34 33 AM

and support link from google: https://support.google.com/faqs/answer/9267555 From this link, i saw a note:

Screen Shot 2021-08-06 at 11 37 42 AM

I think my issue was caused by this packages. Please help!

BaderSerhan commented 3 years ago

I am getting the same issue after using this package. @LightKnight3r did you manage to fix it?

LightKnight3r commented 3 years ago

@BaderSerhan I dont know but following this Google's guide https://developers.google.com/identity/sms-retriever/user-consent/request#2_start_listening_for_incoming_messages , i created new commit to fix this in my fork repo.

LightKnight3r commented 3 years ago

https://github.com/LightKnight3r/react-native-sms-user-consent/commit/f0444918c104d4f2a259b6411f8ed79c268e64bb

BaderSerhan commented 3 years ago

That's great, I'll try it out, thank you! If you want you can create a pull request to this library from your fork and this way you'd contribute a fix to the library. I'm sure @eabdullazyanov would be thankful.

eabdullazyanov commented 3 years ago

Hi @LightKnight3r,

Thank you for posting the issue and for the PR! I merged it and made a release so that the latest version of the package (1.0.10) that includes the fix, can be used.