akveo / kittenTricks

React Native starter kit with over 40 screens and modern Light and Dark theme for creating stunning cross-platform mobile applications.
https://akveo.github.io/react-native-ui-kitten/
MIT License
7.17k stars 986 forks source link

Fix ListHeaderComponent onChangeText re-render issue #297

Closed harveychow closed 3 years ago

harveychow commented 4 years ago

Please read and mark the following check list before creating a pull request:

There's an issue with the ListHeaderComponent (CommentList) where if you type in the input, the whole view is re-rendered when onChangeText is triggered. The solution is to call the renderHeader instead of passing the function to CommentList.

More info here: https://github.com/facebook/react-native/issues/13365#issuecomment-360491719