akveo / nebular

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/nebular
MIT License
8.04k stars 1.51k forks source link

Sidebar menu items don't get unselected #259

Closed bobvann closed 6 years ago

bobvann commented 6 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

When I click an item in the sidebar menu, other items do not get unselected. It was working until few days ago with rc3. Then I deleted node_modules directory and reinstalled packages and it started to misbehaving. Then I updated to rc5 and still bad behavior.

Current behavior: Click an item on the sidebar: it gets selected (class "active" on the "a"). Click an other item, it gets selected too but the first one is not unselected.

Expected behavior: Should remove active class from other items.

Steps to reproduce: (see Current Behavior)

Other information:

Angular CLI: 1.7.0
Node: 6.13.0
OS: linux x64
Angular: 5.2.5
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.7.0
@angular-devkit/build-optimizer: 0.3.1
@angular-devkit/core: 0.0.29
@angular-devkit/schematics: 0.3.1
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.0
@schematics/angular: 0.3.1
@schematics/package-update: 0.3.1
typescript: 2.4.2
webpack: 3.11.0

package.json:

{
  "name": "project",
  "version": "0.0.0",
  "license": "private",
  "scripts": {
    "ng": "ng",
    "start": "ng serve --progress=false",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^5.1.0",
    "@angular/common": "^5.1.0",
    "@angular/compiler": "^5.1.0",
    "@angular/core": "^5.1.0",
    "@angular/forms": "^5.1.0",
    "@angular/http": "^5.1.0",
    "@angular/platform-browser": "^5.1.0",
    "@angular/platform-browser-dynamic": "^5.1.0",
    "@angular/router": "^5.1.0",
    "@nebular/theme": "^2.0.0-rc.5",
    "@ng-bootstrap/ng-bootstrap": "1.0.0-beta.8",
    "angular2-signaturepad": "^2.6.1",
    "angular2-toaster": "^4.0.1",
    "bootstrap": "4.0.0",
    "core-js": "^2.4.1",
    "echarts": "^3.8.5",
    "file-saver": "^1.3.3",
    "font-awesome": "^4.4.0",
    "jquery": "^2.1.4",

Same on all browsers tested
    "moment": "^2.18.1",
    "mydaterangepicker": "^4.1.11",
    "nebular-icons": "^1.0.6",
    "ng2-ckeditor": "1.1.13",
    "ng2-select": "^1.2.0",
    "ng2-smart-table": "^1.2.2",
    "ng2-table": "^1.3.2",
    "ngx-bootstrap": "^1.8.1",
    "ngx-echarts": "^2.0.1",
    "pace-js": "^1.0.2",
    "roboto-fontface": "^0.8.0",
    "rxjs": "^5.5.2",
    "sweetalert2": "^7.1.3",
    "typeface-exo": "0.0.44",
    "zone.js": "^0.8.14"
  },
  "devDependencies": {
    "@angular-devkit/core": "0.0.29",
    "@angular/cli": "1.7.0",
    "@angular/compiler-cli": "^5.1.0",
    "@angular/language-service": "^5.1.0",
    "@types/jasmine": "~2.5.53",
    "@types/jasminewd2": "~2.0.2",
    "@types/node": "~6.0.60",
    "codelyzer": "~3.0.1",
    "jasmine-core": "~2.6.2",
    "jasmine-spec-reporter": "~4.1.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.1.1",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~3.0.4",
    "tslint": "~5.3.2",
    "typescript": "~2.4.2"
  }
}

Same on all browsers tested

mishkolesnikov commented 6 years ago

Hi, @bobvann many thanks for reporting. Unfortunately, I can not reproduce the issue, could you please also share your menu items configuration?

bobvann commented 6 years ago

thanks for the support but unfortunately one month passed and I had to rewrite my own sidebar.

Anyway the menu came from an observable from a rest api following demo sidebar structure

nnixaa commented 6 years ago

Closing for now.