akveo / nebular

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/nebular
MIT License
8.05k stars 1.51k forks source link

NbButtonGroup Reactive Forms #2743

Open KyleInfante opened 3 years ago

KyleInfante commented 3 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

Current behavior: Currently not able to get values from an nb-button-group while used with Reactive Forms. Clicking on any of the buttons in the button group does not update the value in the form. Actually, nb-button-group does not even support the formControlName attribute.

Expected behavior: Similar to how the nb-radio-group works, there should be similar functionality like the nb-button-group. I should be able to use the nb-button-group in a Reactive Form and be able to detect changes when a button is pressed.

Steps to reproduce: I have supplied a Stackblitz showing the issue displayed in the Console and the difference of functionality between button groups and radio groups.

Related code: https://stackblitz.com/edit/nebular-reactive-button-group-issue?devtoolsheight=33&file=src/app/app.component.html

Other information:

npm, node, OS, Browser node version: 13.11.00 npm version: 6.14.11 Windows 10 Chrome

Angular, Nebular "@nebular/bootstrap": "^7.0.0", "@nebular/eva-icons": "^7.0.0", "@nebular/theme": "^7.0.0", "@angular/animations": "~11.2.9", "@angular/cdk": "^11.2.8", "@angular/cli": "^11.2.8", "@angular/common": "~11.2.9", "@angular/compiler": "~11.2.9", "@angular/core": "~11.2.9", "@angular/forms": "~11.2.9", "@angular/platform-browser": "~11.2.9", "@angular/platform-browser-dynamic": "~11.2.9", "@angular/router": "~11.2.9",

andreipadolin commented 3 years ago

Hi @KyleInfante currently nb-button-group doesn't support reactive forms. This feature request depends on activity in this or similar request.

firehist commented 3 years ago

It would be so awesome to get it ready for Reactive Forms!

malachibazar commented 1 year ago

Is this still something on the timeline? I'd love to be able to use the button groups with form controls.