search

akveo / nebular

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/nebular
MIT License
8.06k stars 1.51k forks source link

The close method of WindowRef is not accepting optional return value #3137

Closed kama1 closed 2 years ago

kama1 commented 2 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

Current behavior:

The close method of WindowRef is not accepting optional return value

Expected behavior:

According to documentations and example the close method should accept an optional return value.

Steps to reproduce:

Related code:

Sample usage in repository

Current declaration

export declare class NbWindowRef {
    ...
    /**
     * Closes window.
     * */
    close(): void;
}

Other information:

npm, node, OS, Browser

<!--
Node version: v14.19.0 NPM version: 6.14.16
OS: macOS (Catalina)
Browser: Chrome
-->

Angular, Nebular

    "@nebular/auth": "^8.0.0",
    "@nebular/eva-icons": "8.0.0",
    "@nebular/security": "8.0.0",
    "@nebular/theme": "8.0.0",
kama1 commented 2 years ago

Updated to version 9.0.0 and resolved.