akveo / nebular

:boom: Customizable Angular UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/nebular
MIT License
8.07k stars 1.51k forks source link

[Input] NbInput - debounce #673

Open Tibing opened 6 years ago

Tibing commented 6 years ago

Issue type

I'm submitting a ... (check one with "x")

I think we have to add debounce property to the nbInput directive.

Prefix1802 commented 6 years ago

@Tibing

Could you elaborate why?

Tibing commented 6 years ago

Hi @Prefix1802, I mean, this is a really common use case when you need to add debouncing on your inputs: search, filter, maybe error handling, whatever. And if input itself can't debounce its events you have to write rxjs every time you need debouncing. Anyway, it's just the proposal and has to be discussed.

Prefix1802 commented 6 years ago

@Tibing

I understand now. You said property ;), so we can use it as a parameter.

+1

fabioloreggian commented 6 years ago

How would you like to use the debounce property?

My thought would be a @Input() debounce: number; where this would be the debounce rate in milliseconds?

I am trying my hand at contributing to awesome angular projects and I really fancy nebular and ngx-admin.

sulha199 commented 5 years ago

How would you like to use the debounce property?

My thought would be a @Input() debounce: number; where this would be the debounce rate in milliseconds?

I am trying my hand at contributing to awesome angular projects and I really fancy nebular and ngx-admin.

Agree, and then use the debounce value to pipe the output such as on value change event.

@Tibing ,

Is this issue still open? I am interested to work on it?

yassernasc commented 5 years ago

and then provide a rxjs stream by @Output? but how we can access the input changes inside the nbInput directive?

sethi-ishmeet commented 4 years ago

@Prefix1802 @nnixaa @Tibing

I would like to work on this feature request. I am just starting off to contributing on open source projects on GitHub.

My Proposal:

Please let me know if this is feasible.