akveo / ng2-smart-table

Angular Smart Data Table component
https://akveo.github.io/ng2-smart-table/
MIT License
1.63k stars 877 forks source link

App does not compile with Ivy #1131

Open vusolapohvistr opened 4 years ago

vusolapohvistr commented 4 years ago

Trace: (node:3005) UnhandledPromiseRejectionWarning: Error: Error on worker #2: Error: Failed to compile entry-point ng2-smart-table (fesm5 as esm5) due to compilation errors: node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts:2:22 - error NG6002: Appears in the NgModule.imports of CellModule, but could not be resolved to an NgModule class

2 export declare class Ng2CompleterModule {

node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts:2:22 - error NG6002: Appears in the NgModule.imports of FilterModule, but could not be resolved to an NgModule class

2 export declare class Ng2CompleterModule {

node_modules/ng2-smart-table/fesm5/ng2-smart-table.js:1003:5 - error NG6002: Appears in the NgModule.imports of TBodyModule, but itself has errors

1003 var CellModule = /* @class / (function () {

node_modules/ng2-smart-table/fesm5/ng2-smart-table.js:1433:5 - error NG6002: Appears in the NgModule.imports of THeadModule, but itself has errors

1433 var FilterModule = /** @class */ (function () {

and so on

arthurflor23 commented 4 years ago

Same issue

vicenthy commented 4 years ago

was already upgrading to angular 9

BobCashStory commented 4 years ago

same

shadabk92 commented 4 years ago

whts the solution to this ?

custompro12 commented 4 years ago

whts the solution to this ?

Unfortunately, it seems that the only solution at the moment is to disable Ivy if your application depends on this library.

This library probably won't be updated to support Angular v9 as it is currently not really being maintained. See Low Maintenance notice in the README

BobCashStory commented 4 years ago

@custompro12 not a real solution since ivy make the build way more faster and that why we want to upgrade

arthurflor23 commented 4 years ago

I think this issue is more angular or angular/cli here

giansalex commented 4 years ago

First ng2-completer should be updated.

https://github.com/oferh/ng2-completer/issues/443

dmantelli commented 4 years ago

Same! It's the only component in my project that isn't compatible with Ivy :(

giansalex commented 4 years ago

Other table component options?

mohsenmahoski commented 4 years ago

is there any update or any solution for compatible with Ivy?

osamaalnuimi commented 4 years ago

i think the problem from ng2-completer try to install this version npm install --ignore-scripts ng2-completer@next

giansalex commented 4 years ago

After install ng9 and ng2-completer@next, this change is required: image

majhoos commented 4 years ago

Can we have a time frame on this ng2-smart-table issue? If this component is just an experimental toy-ish component with no potential future then I personally need to hunt for some other components. I am very much surprised that this library with almost 15K downloads a week is getting this level of disregard and abandonment by its own development team.

lenichols commented 4 years ago

@majhoos +1

HackPoint commented 4 years ago

@majhoos I totally agree with you, but I believe they have this product for money, so the have separated the commercial version and this one. In this one they don't invest time.

A question for you, have you found a replacement for this component?

lenichols commented 4 years ago

@HackPoint where is the paid version? If its updated and working I'll need to subscribe to it.

majhoos commented 4 years ago

@HackPoint I have not made any final decision on this yet but one option I have considered so far is the community edition of ag-gird which is free. Their enterprise version is quite expensive and restrictive (in terms of installation) which makes it economically unviable.

evereq commented 1 year ago

Maybe at least merge https://github.com/akveo/ng2-smart-table/pull/1319, which seems to be approved already... We will wait a bit more time, but in the worse case, we will fork and update ourselves (using Smart Table in https://github.com/ever-co/ever-gauzy heavily, not easy to replace)