search

akveo / ngx-admin

Customizable admin dashboard template based on Angular 10+
https://akveo.github.io/ngx-admin/
MIT License
25.18k stars 7.94k forks source link

Back button causes ExpressionChangedAfterItHasBeenCheckedError #1587

Closed daniellmb closed 6 years ago

daniellmb commented 6 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

Current behavior:

Dev Tools console error

NbMenuItemComponent.html:1 ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'max-height: 0'. Current value: 'max-height: 176'.

image

Expected behavior:

Navigate the website without errors.

Steps to reproduce:

  1. Install the latest version
  2. browse to http://localhost:4200/
  3. Click on the Auth menu item
  4. Click on Login
  5. Click on the browser back button.

Other information:

npm, node, OS, Browser

Node, npm: v6.10.2 and 4.2.0
OS: macOS High Sierra (10.13.2)
Browser: Chrome Version 64.0.3282.167

Angular, Nebular

"@agm/core": "1.0.0-beta.2",
"@angular/animations": "^5.2.8",
"@angular/common": "^5.2.8",
"@angular/compiler": "^5.2.8",
"@angular/compiler-cli": "^5.2.8",
"@angular/core": "^5.2.8",
"@angular/forms": "^5.2.8",
"@angular/http": "^5.2.8",
"@angular/language-service": "^5.2.8",
"@angular/platform-browser": "^5.2.8",
"@angular/platform-browser-dynamic": "^5.2.8",
"@angular/router": "^5.2.8",
"@asymmetrik/ngx-leaflet": "3.0.1",
"@nebular/auth": "2.0.0-rc.6",
"@nebular/security": "2.0.0-rc.6",
"@nebular/theme": "2.0.0-rc.6",
"@ng-bootstrap/ng-bootstrap": "1.0.0",
"@swimlane/ngx-charts": "7.0.1",
"angular2-chartjs": "0.4.1",
"angular2-toaster": "4.0.1",
"bootstrap": "4.0.0",
"chart.js": "2.7.1",
"ckeditor": "4.7.3",
"classlist.js": "1.1.20150312",
"core-js": "2.5.1",
"echarts": "^4.0.2",
"font-awesome": "4.7.0",
"intl": "1.2.5",
"ionicons": "2.0.1",
"leaflet": "1.2.0",
"nebular-icons": "1.0.6",
"ng2-ckeditor": "1.1.13",
"ng2-smart-table": "1.2.2",
"ng2-tree": "2.0.0-rc.4",
"ngx-echarts": "2.0.1",
"normalize.css": "6.0.0",
"pace-js": "1.0.2",
"roboto-fontface": "0.8.0",
"rxjs": "5.5.5",
"socicon": "3.0.5",
"tinymce": "4.5.7",
"typeface-exo": "0.0.22",
"web-animations-js": "2.2.5",
"zone.js": "0.8.18"
MohamedGamil commented 6 years ago

I'm facing the same issue..

nnixaa commented 6 years ago

Let's keep track on this one here https://github.com/akveo/nebular/issues/263.

nnixaa commented 6 years ago

fixed in v2.1.1

Ahmore commented 6 years ago

Error is gone but max-height still is not as expected. It equals 16px. And my submenu is still hidden like before. Look at screen below. image