akveo / ngx-admin

Customizable admin dashboard template based on Angular 10+
https://akveo.github.io/ngx-admin/
MIT License
25.28k stars 7.96k forks source link

NbSidebar Events not firing in responsive mode #2149

Open elucidsoft opened 5 years ago

elucidsoft commented 5 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

Current behavior: If you have a sidebar with responsive set on it and suscribe to the onCollapse and/or the onToggle Observables there are no events fire when you resize the window and the sidebar collapses itself.

Expected behavior: The proper events fire when the sidebar collapses itself from the responsive behavior.

Steps to reproduce:

Related code: <nb-sidebar responsive="true">

public ngOnInit(): void {
    this.sidebarService.onToggle().subscribe((value) => {
      this.isSidebarExpanded = !this.isSidebarExpanded;
      console.log('toggle');
    });

    this.sidebarService.onCollapse().subscribe((value) => {
      this.isSidebarExpanded = false;
      console.log('collapsed');
    })

  }
eltharynd commented 3 years ago

Not sure if it's the same issue but they're actually only not firing from mobile...

My guess is it's a (click) v (tap) issue