Add Unit Testing and E2E testing framework; Modals

[tonyhayes]

• I'm submitting a ... [ ] bug report [X ] feature request [ ] question about the decisions made in the repository
• Do you want to request a feature or report a bug? Feature

Hi - I've added a simple modal to replace the window.confirm in the smart tables and unit test and e2e frameworks (I've also added toastr)- would you like me to push these up?

No worries either way.

[nnixaa]

Hey @tonyhayes, we would love if you submit the changes you made as pull requests. One thing - will you be able to submit them separately per the functionality added? Thanks!

[tonyhayes]

I've separated my changes into individual commits .. but how do I submit these changes - I can't just push them up into master ?

[nnixaa]

@tonyhayes please take a look at this explanation https://yangsu.github.io/pull-request-tutorial/

[tonyhayes]

I got this message;

Switched to a new branch 'pull-request-1' DCIs-MacBook-Pro:ng2-admin thayes$ git push origin pull-request-1 Username for 'https://github.com': tonyhayes Password for 'https://tonyhayes@github.com': remote: Permission to akveo/ng2-admin.git denied to tonyhayes. fatal: unable to access 'https://github.com/akveo/ng2-admin.git/': The requested URL returned error: 403

[sielay]

@tonyhayes that isn't the way that the pull requests work. You do changes in your own fork and commit them there (to master or branch, how you like). Then you can use a command line or better GitHub to create a pull request. Pull request compares your fork and upstream (this repository). Only owners of the repository are allowed to merge. You won't ever get permissions to commit directly to master. Take that lesson, it's a standard, will help you a lot in the future. Best

[nnixaa]

Closing as unfortunately it's too old.

[ramsunvtech]

@nnixaa, Reopen this issue. iam planning to contribute in Unit Testing but in Jest.

[nnixaa]

Hi @ramsunvtech, thank you for your suggestion, but unfortunately I don't think we want to use Jest, since we already use the default Angular setup (Karma + Jasmine) in Nebular (which is a UI library for ngx-admin) and it doesn't make sense to introduce additional library into the environment.

[ramsunvtech]

No Problem. If that is the case, then i'm fine with Karma + Jasmine

[StanislavChankov]

Hello @nnixaa I have everything setup to contribute like ssh keys and stuff. I am trying to push into my branch, but i an receiving the same error: I think that the problem comes from the reason that I am not added to the contributors group for this repository. Could you help me, please?

[yggg]

@StanislavChankov You need to fork repository and then push changes to your fork. Then you'll be able to submit pull requests to this repository. https://help.github.com/en/articles/fork-a-repo https://help.github.com/en/articles/creating-a-pull-request