akveo / react-native-ui-kitten

:boom: React Native UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/react-native-ui-kitten/
MIT License
10.33k stars 953 forks source link

Select: placeholderMarginHorizontal console warning #1103

Closed Dammic closed 3 years ago

Dammic commented 4 years ago

🐛 Bug Report

Variable placeholderMarginHorizontal is no longer used (but left in mapping), which causes console warning. As you can see here, it was used in the previous version (one commit before 5.0.0): https://github.com/akveo/react-native-ui-kitten/blob/ff7b5a5bd5943605d2b1d13faec0161dad7a45fa/src/components/ui/select/select.component.tsx#L362 But in the current one, it's not used: https://github.com/akveo/react-native-ui-kitten/blob/master/src/components/ui/select/select.component.tsx#L337

As one can see, in the newest eva-design/eva this variable is still present: https://github.com/eva-design/eva/blob/master/packages/eva/mapping.json#L3691

To Reproduce

Steps to reproduce the behavior: NA - simply try to use Select component on a normal github project, and the warning (error) should be in console.

Expected behavior

There is no warning in the console.

UI Kitten and Eva version

Package Version
@eva-design/eva 2.0.0
@ui-kitten/components 5.0.0

Environment information

  System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 13.12.0 - ~/.nvm/versions/node/v13.12.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v13.12.0/bin/npm
  IDEs:
    Xcode: /undefined - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz => 0.61.4

EDIT: Ah, of course I've forgot to put in the warning: Screenshot 2020-05-19 at 14 39 13

Roeefl commented 4 years ago

This happens to me as well

GlCap commented 4 years ago

I too have this problem.

topwebtek7 commented 4 years ago

still having this issue, any workaround to this yet?