akveo / react-native-ui-kitten

:boom: React Native UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/react-native-ui-kitten/
MIT License
10.19k stars 952 forks source link

Remove defaultProps from MeasureElement component #1818

Open rklomp opened 1 month ago

rklomp commented 1 month ago

Please read and mark the following check list before creating a pull request:

Atsukoro1 commented 1 month ago

Please review this, the error is really annoying and it will destroy the library in future

rklomp commented 1 month ago

@greenfrvr, Are you still involved with this repo?

rklomp commented 2 weeks ago

@elupanov

greenfrvr commented 2 weeks ago

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

rklomp commented 2 weeks ago

Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props.

MeasureElement is the only function component I could find using defaultProps. The others are class components.

vilnytskyi commented 1 week ago

@greenfrvr please merge this one, as defaultProps in class components are still acceptable to use for now.

vilnytskyi commented 1 week ago

I've posted a workaround to fix this one and #1782 until this PR is approved