search

akveo / react-native-ui-kitten

:boom: React Native UI Library based on Eva Design System :new_moon_with_face::sparkles:Dark Mode
https://akveo.github.io/react-native-ui-kitten/
MIT License
10.28k stars 951 forks source link

Modal positioned by screen size (not browser size) on web #699

Closed AndyHubert closed 4 years ago

AndyHubert commented 4 years ago

Issue type

I'm submitting a ... (check one with "x")

Issue description

Current behavior: The component attempts to center its positioning. However, on web, it bases its calculation off of the monitor width, not the browser width. Thus, if the browser width is less than the full width of the monitor, the Modal's positioning will not be centered.

Expected behavior: For web, the component should center its x position on the browser window width.

Steps to reproduce: Use a Modal with react native web, and open up in a browser window which does not extend the full width of the monitor.

Related code: The offending line of code

Other information:

OS, device, package version

React Native Web
artyorsh commented 4 years ago

Hi 👋 Thanks for reporting this!