akvo / akvo-caddisfly

Android app integrated with Akvo Flow
https://akvo.org/products/akvo-caddisfly/
GNU General Public License v3.0
12 stars 9 forks source link

Uncaught exceptions #37

Closed ldporsius closed 8 years ago

ldporsius commented 8 years ago

In case an uncaught exception is thrown, do not let the app crash, but handle it in a way that gives users:

ldporsius commented 8 years ago

There are quit a few options to deal with this, as I learn reading the posts on Stack Overflow. Some include external libraries, which might be a good idea, because they offer the possibility to read back the information from media that are independent of your application. But I am now developing in a sub-branch of the larger scope that is called Akvo-flow, therefore it is not the place to introduce anything of that kind. Within this scope we can do the following:

mtwestra commented 8 years ago

But we don’t know if it is an uncaught exception?

On 2 Dec 2015, at 18:46, Linda Porsius notifications@github.com wrote:

There are quit a few options to deal with this, as I learn reading the posts on Stack Overflow. Some include external libraries, which might be a good idea, because they offer the possibility to read back the information from media that are independent of your application. But I am now developing in a sub-branch of the larger scope that is called Akvo-flow, therefore it is not the place to introduce anything of that kind. Within this scope we can do the following:

Write a class that extends Application In the onCreate() tell what to do with uncaught exceptions In the manifest, tell that when uncaught exception occurs, start an Activity that handles it. — Reply to this email directly or view it on GitHub https://github.com/akvo/akvo-caddisfly/issues/37#issuecomment-161378047.

ldporsius commented 8 years ago

That's the point. Some exceptions you try and catch, some you do not foresee, hence the uncaught exception handler. I assume you are referring to the crash on the Motorola device we are struggling with. That crash is not caught by this handler. But in general it might still be a good implementation?

mtwestra commented 8 years ago

Let’s first try to find out what the actual cause is, otherwise we are implementing a solution without knowing the problem

On 3 Dec 2015, at 08:30, Linda Porsius notifications@github.com wrote:

That's the point. Some exceptions you try and catch, some you do not foresee, hence the uncaught exception handler. I assume you are referring to the crash on the Motorola device we are struggling with. That crash is not caught by this handler. But in general it might still be a good implementation?

— Reply to this email directly or view it on GitHub https://github.com/akvo/akvo-caddisfly/issues/37#issuecomment-161540731.

ldporsius commented 8 years ago

Sorry, but this issue is about uncaught exceptions. Let's discuss Motorola crash in another medium.

ldporsius commented 8 years ago

Code is not part of integration into Caddisfly structure. Closing.