akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

Flow lists theme #1593

Closed valllllll2000 closed 4 years ago

valllllll2000 commented 4 years ago

Scope

This issue tackles the list items styling in a general sense. We have them common to Datapoint list, Form list and Response list.

Background

btw had there been a special reason to use different backgrounds for the list items? I think a white background for all datapoints or if need with dividers for list items would make list items visually clean; I am referring here also to list items under Forms and History tabs.. but may be this is an different issue for another day

Originally posted by @Kiarii in https://github.com/akvo/akvo-flow-mobile/issues/1592#issuecomment-594347929

Currently, the lists of items in flow app are displayed with alternate backgrounds:

TODO

Remove alternate backgrounds, list backgrounds should be white Add a small divider to the lists

valllllll2000 commented 4 years ago

Here is a screenshot @Kiarii what do you think

Kiarii commented 4 years ago

@valllllll2000 we can bold just the datapoint name, to make the text easier on the eye; sth like this image

valllllll2000 commented 4 years ago

@Kiarii we bold the new datapoints as per issue https://github.com/akvo/akvo-flow-mobile/issues/1592

Also this issue is about: remove alternate background, add seprator

Kiarii commented 4 years ago

I've copied my comment over to #1592

valllllll2000 commented 4 years ago

Here is the updated screenshots for our lists

Datapoint list (the separator has a left and right padding)
Forms (the separator has a left and right padding)
History (the separator has a left and right padding)
Transmission History (the separator has no padding)
Offline maps list (the separator is thicker)
valllllll2000 commented 4 years ago

Here are the updated screenshots

Kiarii commented 4 years ago

Looking good :)

However, it seems that for the Forms screen - the screen in the middle - there is no divider between the Registration and Monitoring form..

valllllll2000 commented 4 years ago

Fixed that issue where disabled items had no separator in list

muloem commented 4 years ago

👍 I like what I am seeing!