akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

Data point list styling: date #1604

Closed valllllll2000 closed 4 years ago

valllllll2000 commented 4 years ago

Background

Currently we display the datapoint modified date: "Last modified x minutes/hours/weeks ago", see:

@Kiarii's proposal:

I would also like to propose an improvement on how we show the modified time; atm we are presenting as a primary element of the list and repeating the “Last modified:” for each datapoint which i think does not add extra value.. I think just showing the day is enough and it also enables us to get rid of the “ago” which we are atm also repeating for each list item.. what are your thoughts

Here is a screenshot of how it could look like: image

Questions and Thoughts

Position the date on the right, in my opinion is a very good idea.

As for the formatting, if it's today will we show today or Mar 9? Wouldn't it still be useful to show more details for today, ie 10 minutes ago or a second ago? How would it benefit the user, less information?

Kiarii commented 4 years ago

@valllllll2000 these are some valid questions,

I think we could for changes made today use time (with 24hr notation) e.g. 10:12, 18:27, or so.. and then change to dates e.g. Mar 9, once the last modified time is yesterday and so on..

This way, i think we can keep the timestamp short and also exact; e.g. instead of 10 mins ago, we say 10:02. I also think with the 10:02 Alphonso can precisely tell when a modification was made to a datapoint - which i think is the idea..

valllllll2000 commented 4 years ago

Screenshot_1586342581

janagombitova commented 4 years ago

It is a great change in terms of making the screen cleaner. But I have two comments/issues with it:

janagombitova commented 4 years ago

To be able to push out the change of design but not loose information we give to users we can keep the change of date layout and format but standardise it to (also what Lumen is using):

and then see if we can simplify it more with another iteration

valllllll2000 commented 4 years ago
valllllll2000 commented 4 years ago

@janagombitova I have just realized maybe it would be best to let the formatting be according to the language. Here is an example side by side of I use the default for US English and French What do you think?

janagombitova commented 4 years ago

I think that is very smart!

valllllll2000 commented 4 years ago

@janagombitova After using the app I have noticed that we put the date next to the datapoint name (top right), and sometimes that name is very long:

I wonder if it wouldn't make more sense to put the date at the right/bottom or right middle, see below:

janagombitova commented 4 years ago

The middle looks best to me. Good catch

janagombitova commented 4 years ago

IMG_1792 I am reopening this issue as I think we need to reconsider the design once more. We made the change using a short data point name. But in practice the names are long (consisting of more answers). The changes now result in a lot of white space and less data points visible in the screen as one takes up a lot of vertical space.

@Kiarii and @valllllll2000 what do you think?

valllllll2000 commented 4 years ago

That does not look nice at all, I would in this case suggest putting the date at the bottom on the same level as status which is usually short, see for example:

janagombitova commented 4 years ago

Putting the date down is also a way to go, but then I wonder why not keep it in line with the rest...

Do we have three different font sizes? Maybe we can make the ID, status and date the same size - small and decrease the font of the name too. How about also limiting the spacing a bit between lines to save space?

And third thought, I know we spoke about it before and said we should keep the time stamp, so you know which point came sooner. But after looking at some other apps, I think we could remove it for older points (from yesterday onwards). What do you think?

Kiarii commented 4 years ago
janagombitova commented 4 years ago

That is one long list of suggestions :) I made a summary of straightforward changes and then a list of what we still need to discuss clarify. I suggest we have a meeting with the three of us to talk them through.

Changes

To discuss:

valllllll2000 commented 4 years ago
  • [ ] Do not show DP ID in the list (if we move to the DP screen) - I think this is worth the experiment and to see if we hear back from users that they miss seeing this value in the list

The datapoint id is one of the fields that can be searched, do we really want to remove it?

valllllll2000 commented 4 years ago
  • Show DP location stamp in DP screen when location/gps info is available for a DP. Should this be clickable to view on the map?

Sounds good, currently we show distance from current location and it is also used the datapoints by distance.

  • Moving the status icon to the left and removing the text description.

But the status icon is already on the left? Do you mean top left?

janagombitova commented 4 years ago

Today, Valeria, Kiarii and I met to discuss the proposed changes and how to go about therm There are the decisions we made:

valllllll2000 commented 4 years ago

Here is how it could look:

Kiarii commented 4 years ago

already the list is noticeably cleaner :) small observation:

Kiarii commented 4 years ago

After some deliberation and experimenting with icons for the datapoint states, I am tentative concluding that..

janagombitova commented 4 years ago

@Kiarii just one question: Why not use the spinner for the submitted state then? It indicates the 'progress' of uploading (if happening or not due to connection, but Flow keeps on trying). Plus as an extra plus point for the spinner, looking at the screens it is hard to see at first glance the difference from the circular time and circular tick.

valllllll2000 commented 4 years ago

@Kiarii just one question: Why not use the spinner for the submitted state then? It indicates the 'progress' of uploading (if happening or not due to connection, but Flow keeps on trying). Plus as an extra plus point for the spinner, looking at the screens it is hard to see at first glance the difference from the circular time and circular tick.

I like the "time" icon for "pending" state because we don't know if it will be uploaded or not or when. The spinner really means something is happening now and it may be not the case. We do show "uploading" notification when datapoints are being uploaded. But I do agree the icons are too much a alike at first I though we only had 2 states. Maybe the tick should not have a circle in it?

Also another thought: I can create a prototype with both black and white and colored versions and see how it looks so we compare

janagombitova commented 4 years ago

@valllllll2000 ok then. Let's use the time. And a prototype with 2 options sounds perfect 👍

valllllll2000 commented 4 years ago

janagombitova commented 4 years ago

I like the 1st colourful one. But curious to hear @Kiarii 's thoughts

valllllll2000 commented 4 years ago

New example taking into account Kiarii's recommendations Screenshot_1592475947

janagombitova commented 4 years ago

It is looking promising. My only note is that we agreed not to move to black-n-white icons to not implement too many changes and to not loose the "quickly scan to see the status of my submissions" feeling the colours provide.

valllllll2000 commented 4 years ago

Here is an example of colored icons (with 54% opacity) Screenshot_1592553501

valllllll2000 commented 4 years ago

and full opacity color Screenshot_1592553981

valllllll2000 commented 4 years ago

the date stamp should take a smaller font size - since it is an element of a secondary or tertiary importance in the datapoint component - when it is of the same size as the datapoint, it competes for prominence with the name which is the primary element.. (this is also the case with apps such as messaging and chat apps)

Kiarii commented 4 years ago

All datapoints are equal but some are more equal than others; the inequalities

In which case, the alignment of datapoint elements appear as being visually unbalanced; image

Given this inequalities, keeping the status icon on the left makes more sense, since the elements of a datapoint are located in visually balanced manner e.g.

image

NB [for later] For surveys without a location or geoshape question - it makes no sense to provide the MAP Tab as an alt view to the datapoints

About the color coding, am still reluctant to keep it given that :

janagombitova commented 4 years ago

@Kiarii I hear your concerns about the colour coding, but I am going to use my power of veto this time and say, we keep the colours. We are changing enough already in the screen. If this change is taken positively and users get used to it, then we can again reopen the discussion on taking away the colours for the icons.

valllllll2000 commented 4 years ago

Latest screenshot with the requested changes

Kiarii commented 4 years ago

Notes for more improvement:

valllllll2000 commented 4 years ago

Notes for more improvement:

  • For the check icon lets try a green: 00AB34

Done

  • Align the status icon to middle of the first line of the dp name. The size of the icons, i will comment after test driving the emerging visual hierarchy..

OK

  • The distance and time stamps are secondary to the datapoint name. If the dp name is 16px, lets see how the component looks as a whole with distance as 14 and time as 12.

Done, we used sp instead of pixels so its 16sp, 14sp and 12sp

  • Dp name line height: 24, dist stamp line height: 20

I don't understand what this refers to, maybe a screenshot could help, does it mean the height of the textview?

  • datapoint name and accompanying metadata stamps take black (000000) as the font color with alphas of 87 and 54% respectively

What is those metadata stamps? For now what I did is datapoint name text color #DE000000 (the first 2 refer to alpha) and distance and time #8A000000 not sure it's what you meant

Kiarii commented 4 years ago
Screenshot 2020-06-22 at 10 55 50
valllllll2000 commented 4 years ago

Screenshot_1592833222

valllllll2000 commented 4 years ago

New version after Kiarii's recommendation: Screenshot_1592897741

valllllll2000 commented 4 years ago

There seems to be a visual defect in some cases where location is missing:

1) The space is empty when the distance is missing, there should be only one line in this case 2) For some reason only 1 of the 2 points is displayed, reloading the app corrects the issue

Another issue, I forgot to implement: "

With search, we need to reveal the ID when searching and hide when Al is not searching

"