Make manual loading of survey in wrong FLOW app impossible

[mtwestra]

Some mobile users manually transfer a survey from one FLOW instance to a FLOW app from another instance. This can happen when an enumerator collects data using different FLOW instances, and doesn't install the correct FLOW app for a given survey.

Proposed solution: 1) Include the GAE app id in the survey definition XML 2) In the FLOW app, on loading a manually transferred survey, check if the survey XML app id corresponds to the data server as set in the FLOW app. If they don't match, display a toast saying that the survey does not belong to this FLOW instance app.

Corresponding FLOW Dashboard issue: https://github.com/akvo/akvo-flow/issues/1071

[ichinaski]

I'd suggest to leverage the existing notification errors (they now include meaningful messages), rather than showing a temporary toast.

cc/ @mtwestra

[mtwestra]

agreed

[ichinaski]

Test plan:

• Edit and (re)publish any form, ensuring app property is present in the XML file
• Perform a bootstrap import:
  • Using the appropriate instance's APK, the import should succeed.
  • Using a different instance's APK (any would do the trick), the process should fail, showing a toast message (pop-up) in addition to the regular error notification.
• Backwards compatibility test: Bootstraping legacy forms (no app property) is allows, regardless of the instance they belong to.

[rumca]

The above test plan passes as described :+1: