search

akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

Caddisfly question type #421

Closed ichinaski closed 7 years ago

ichinaski commented 8 years ago

Formerly known as External source question, Caddisfly will now have its own question type: https://github.com/akvo/akvo-flow/issues/1577

janagombitova commented 8 years ago

As explained above, we have implemented a new question type for Caddisfly water quality tests (fluoride, EC and strip tests). The user adds a specific test to his survey as a question, in the app the user click on the start tests button that brings him into to Caddisfly app and the test. After a test is successfully completed the app opens Flow nicely, but in the answer field we only show: "Test captured successfully"

It would be useful to show the value captured instead. It does not have to be the full image and value as shown in the Data tab, but the value itself will tell the user more about the water sample.

muloem commented 7 years ago

@janagombitova this was already integrated in the app in version 2.2.4 but requires testing along with the dashboard implementation

janagombitova commented 7 years ago

@muloem all right, will test it once UAT and the app are ready for testing 👍

Test plan

  1. Create a survey in the dashboard that holds the new Caddisfly question. Create a question for each test type. Add the survey to an assignment for your phone.
  2. Download the Caddisfly apk and make sure you have all the extras needed to run the Caddisfly tests.
  3. Open the Flow app, start the survey with the Caddisfly questions in it.
  4. Once you reach the question and button should be shown to run the test
  5. Click on it and the Caddisfly app should open immediately on the test for your question
  6. Run the test.
  7. After the test is completed you should be brought back to Flow app and the result should be indicated in the answer field
  8. Continue with the other questions, skip one mandatory Caddisfly question and try to submit the form
  9. You should not be able to do so, go back to the question and run the test
  10. Submit the form
  11. Make sure you can view the form submission on the app and all answers are shown properly
  12. Make sure answers were properly synced to the dashboard
janagombitova commented 7 years ago

Notes from test 1

All current tests available for the users to select render on the Flow app properly with the Go to test button. The test triggers the Caddisfly app with the proper test selected.

I could not run the actual EC tests as my phone does not support OTG and neither the fluoride test as we did not have a kit in the office. The strip tests worked ok in terms of apps communicating with each other. Regarding the quality and UX of the tests - this issue does not over these points.

The only issue I could find was the fact that the tests do not run in repeated question groups. This problem will be handled in another iteration. https://github.com/akvo/akvo-flow-mobile/issues/475

Secondly, once the test is done in Flow app we only show that is was successful and not the captured value. For the user it will be better to see the value https://github.com/akvo/akvo-flow-mobile/issues/470 Also for another implementation

For no the issue passes the test plan 👍