search

akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

Do not check for notifications before deviceId is set #484

Closed stellanl closed 7 years ago

stellanl commented 7 years ago

This is the other half of #454, addressing akvo/akvo-flow#1731. DataSyncService does the same thing as SurveyDownloadService, so should be delayed the same way.

stellanl commented 7 years ago

Test plan: same as for #454; Install the app on a device. Wait several minutes before pressing Next on the Add User screen. The device should not appear in the device list until after you do.

janagombitova commented 7 years ago

👍 issue passes test plan. I have one question though looking at the referenced issues: Is this change supposed to fix the missing version info in the Device list @stellanl ?

stellanl commented 7 years ago

The only connection is that I discovered this while researching akvo/akvo-flow#1819.

janagombitova commented 7 years ago

👍 all clear. Ready for release