Error notification icon is shown as empty white circle

[valllllll2000]

The issue:

Turns out as the icon id is passed as null for the notification when there was an error downloading forms.

When this id is null, R.drawable.info is used, but it is only defined for drawable-hdpi.

After talking to @janagombitova it has been decided we should use the akvo icon.

What has been done:

Modify the way notifications are shown. Added new akvo icon. Informative/progress notifications shown in orange. Error notifications are in red. There is a difference between how they are shown in different android versions (see screenshots below). Older devices will only show a white icon (no color available)

Test plan:

Ideally test all case where the notifications are displayed, either success or error. If possible test on older devices (< android 5) and also android 5/6 and 7.

[valllllll2000]

[valllllll2000]

@janagombitova after looking at the other icons used (see for example the one on the screenshot for Downloading forms, we should use a white icon, the akvo app icon cannot be used here. The proposed icon to use is android.R.drawable.ic_dialog_alert, see my screenshot below of how it will look:

Additionally, the same icon will be used for the status bar icon, see red arrow:

[valllllll2000]

after talking to @loicsans it has been decided to use the same icon for all flow notification icons:

[muloem]

@loicsans Shouldn't we distinguish between the kinds of notifications based on what the error actually is? if it is simply informational notification, I agree that we can use the Akvo icon but I think error notifications could perhaps stand out more.

Also is it possible for the icon to be coloured or does that look weird at that small size?

@valllllll2000 @janagombitova

[valllllll2000]

@muloem the icon has to be black and white as it is used for the status bar. A colored icon just shows an empty white square.

[muloem]

ok.. and having an orange background?

[valllllll2000]

I can try @muloem, this usually works on lollipop and on Nougat the icon can be colored as well but no background, I will try now and upload some screenshots to see how it looks.

[valllllll2000]

Nougat (Android 7.0)

Lollipop and ++ (Android 5.0 and 6.0)

[valllllll2000]

@loicsans @muloem I have an idea: maybe for error notifications, we could put the color red instead of orange to make a distinction, so only issue is color is only shown for android Lollipop or more recent devices.

[muloem]

I agree. But I guess @loicsans view holds more weight here

[loicsans]

Making the distinction between the 2 types of notification is a good idea. Let's try red for errors.

[valllllll2000]

For devices with Android <3.0 we need to show different icons (grey color and diferent sizes) here is how it will look like:

[janagombitova]

@valllllll2000 can you specify the test plan a bit and clarify if the notifications are to be of a colour or not? if the icons differ? etc? Thank you

[valllllll2000]

Updated test plan:

The look of the notifications will be diferent according to Android version (there is no way around that).

• < 5.0: Small grey akvo icon, no color, error and normal notifications are shown the same way. Here is a picture:

• All others the notifications have colors (orange for ok and red for error). The look will change between 7.0 and the rest of them but the colors are still the same. Here is an example on Android 6.0 tablet with an error:

and this this android 7.0 (success notification)

[janagombitova]

@valllllll2000 my Akdroid 4.4.2 is showing all notifications ins grey. Besides that comment the Akvo icon is shown ok as well as the notifications themselves.

[valllllll2000]

@janagombitova sorry I have no android 4.xx phone but yes it is correct, the color has been added in 5.0 not 3.0 as I initially specified, sorry about the mistake, I have corrected the test plan.

[janagombitova]

@valllllll2000 ohh ok. Then all is clear and works as expected. 👍