search

akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

When device is rotated user is shown the download update dialog again #499

Closed valllllll2000 closed 7 years ago

valllllll2000 commented 7 years ago

Steps to reproduce: Install an app for which there should be an update Open app you will see the dialog of the screenshot Press no Rotate device You will see the dialog again

This could be annoying of the user does not want or cannot update now so we have decided with @janagombitova that we will display the dialog only once every 24 hours if the user pressed "no".

Of course for the user to be able to update later we need to add a way to update from the settings screen (see issue https://github.com/akvo/akvo-flow-mobile/issues/500)

See screenshot: screenshot_20161110-162227

valllllll2000 commented 7 years ago

Test plan:

1) Open the app that has not yet been updated (we will probably need a special build for that). Come back after 24h and open the app. The dialog should be shown. the dialog will be shown, press no, rotate the device, make sure the dialog is not shown a second time. The first time, it may take up to 24h to display the dialog because the task is scheduled to run about every 24 hours. 2) Please also test going to settings -> check for updates. This task will the be run immediately and the dialog should be shown each time you request the update if there is one.

For now, only versionName with the format "x.y.z" is taken into account, that is, it would recognize 2.2.9 but not 2.2.9_alpha. It does not compare versionCodes since the backend code does not provide them.

janagombitova commented 7 years ago

@valllllll2000 is this not handled with the implementation in the other issues? or in the apk that I tested?

valllllll2000 commented 7 years ago

@janagombitova this is not finished. I made some changes but there is a class present in newer google api which would be perfect for this case so I am waiting on some decision to be taken on that other task.

valllllll2000 commented 7 years ago

This ha been developed as discussed previously with @janagombitova but after talking to @muloem he has suggested we should maybe not block the user at all but display a notification and that maybe a check once a week will be sufficient. In the meantime this is still an improvement over what is currently there.

janagombitova commented 7 years ago

I can confirm that nothing extra is shown to the user when the device is rotated. Will cross check this issue once more after I have the 2.2.9 build to be able to update the version. Leaving the issue in ready for testing for the time being

janagombitova commented 7 years ago

👍 all ready to go