search

akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

Remove location beacon sending #550

Closed valllllll2000 closed 7 years ago

valllllll2000 commented 7 years ago

After discussing with @janagombitova the increased costs of google app engine it has been decided to study the possibility to remove the location beacon sending feature.

Right now, the location beacons are only sent every 30 minutes if the user enables the feature in the settings. The questions is: is the data useful to someone and is it being used. Can we safely remove this?

We should check the "expensive" instances and see if some location data being sent recently may be the culprit.

janagombitova commented 7 years ago

Here are some old issues that touch upon the topic of location beacon and tracking the location of apps: https://github.com/akvo/akvo-flow-mobile/issues/384 and https://github.com/akvo/akvo-flow-mobile/issues/19

The purpose of the location beacon was originally to track the location of all phones at all times.

Considering:

I think we should remove this feature fully from the app. @valllllll2000 @stellanl @muloem and @LarsSjogreen What do you think?

valllllll2000 commented 7 years ago

I agree to remove it if nobody is using it. If we need location for a survey it can be added as a question by users.

valllllll2000 commented 7 years ago

It has been decided to remove the location beacon sending. Remove the LocationBeaconService and all its dependencies. Remove the setting in the app to allow activating the location beacon sending.

valllllll2000 commented 7 years ago

Test plan:

Just go to Settings -> Preferences, the beacon setting should be gone.

janagombitova commented 7 years ago

Beacon gone! Well done everyone, this is a big step towards simplification and confirming it is good to remove elements we make no use of anymore 👍