search

akvo / akvo-flow-mobile

Akvo Flow app
GNU General Public License v3.0
18 stars 16 forks source link

GeoQuestion Location Timeout #675

Closed valllllll2000 closed 7 years ago

valllllll2000 commented 7 years ago

Instead of the current TextView with the Text "timeout" we will display a snackBar with a retry button

valllllll2000 commented 7 years ago

screenshot_1490633147 Here is how it looks so far @janagombitova. About the error messages, not sure if we should put "Error getting location" or "timeout getting location" or the one that you can see on the snackbar already which is "Unable to get location.".

janagombitova commented 7 years ago

@valllllll2000 it is looking very good. I would use Unable to get location (without the ".")

Once Alphonso clicks on Retry, will the Chech Geo Location button be disabled as mentioned in this https://github.com/akvo/akvo-flow-mobile/issues/673 issue?

valllllll2000 commented 7 years ago

@janagombitova Yes, it will but I will work on that in the issue #673

Here is the new screenshot. screenshot_1490696610 I have changed the accuracy string as well as I was finding it confusing it used to say "Acc:" and now it is "Accuracy: unknown".

valllllll2000 commented 7 years ago

Test plan

Enable location on your device. While being inside of a building you should not get gps location on most devices and since we have a timeout of 60 seconds you should be able to reproduce the timeout every time. Assign a survey with a location question. Press "check geo location". Wait for 1 minute. You should see Snack bar as on the screenshot above. Pressing "retry" will attempt to fetch the location again.

janagombitova commented 7 years ago

@valllllll2000 it all works as it should but I do not like that the snackbar disappears so quickly from my screen, I did not even get to notice what it was saying and what I can do. Can you automatically time it out after a bit longer time?

janagombitova commented 7 years ago

Better. Thanks 👍