search

akvo / akvo-flow-services

Akvo Flow service applications for reporting, bulk uploads and others
Other
4 stars 1 forks source link

Check validation of the survey during import #173

Closed muloem closed 3 years ago

muloem commented 6 years ago

When importing a survey, we validate the survey being imported by checking that the IDs of the questions (found in the spreadsheet header row) are a subset of the questions that are used in the survey. However, we use the latest state of the survey rather than the latest published state of the survey to check this. For cases where questions have been added to the survey, this check works but it should fail for cases where questions have been deleted from the survey.

In the change planned in https://github.com/akvo/akvo-flow/issues/2285, we will use the latest published version of the survey, but we need to decide then how the validation of the import works in this case.

stellanl commented 4 years ago

The Java-centric solution is to drop this check from the Clojure code, and add it to the validate() method as part of #3093.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.