search

akvo / akvo-flow

A data collection and monitoring tool that works anywhere.
http://akvo.org/products/akvoflow/
GNU Affero General Public License v3.0
65 stars 31 forks source link

CartoDB maps - question order in side bar not the same as in survey definition #1593

Closed janagombitova closed 7 years ago

janagombitova commented 8 years ago

When previewing data in the Maps that run CartoDB, the order of the questions in the form is not the same as they are defined in the survey.

screen shot 2016-03-07 at 10 20 42 screen shot 2016-03-07 at 10 20 51
janagombitova commented 8 years ago

Link to issue in Reamaze: https://akvoo.reamaze.com/admin/conversations/map-display-order-of-fields

kymni commented 8 years ago

Questions order seems to be correct in relation to what is returned by the cartodb api. Possibility for difference highlighted in the issue could be changing the questions order after you've already published the form. A fix for this would be to change the questions endpoint to one that would pull the questions list directly from FLOW. That way we would always have the latest questions order

kymni commented 8 years ago

Questions list now pulled from dashboard and sorted based on order before being displayed on details panel. This is a temporary solution pending fixing of issue akvo/akvo-cartodb-consumer#19

kymni commented 8 years ago

Test plan

Compare the order of questions in any survey with the order of question answers that appear on the CartoDB maps' details panel when a user clicks on a point. The order in both cases should be the same

janagombitova commented 8 years ago

@kymni Charles, is this the issue where you already have the implementation ready, just needed to fix some conflicts and needed review?

kymni commented 8 years ago

@janagombitova yes it is

janagombitova commented 8 years ago

Could not fully check this issue due to https://github.com/akvo/akvo-flow/issues/1694#issuecomment-228308449

On the map only one question group showed and not all. In that one group the question order was correct. Once we learn and enable to show all questions groups, I can continue to test out the question order

janagombitova commented 8 years ago

Not sure if any fixes were done to the above mentioned issue but the test plan passes as expected 👍

The loading of a 105 question survey in the side bar was not an issue.

kymni commented 8 years ago

Questions in correct order but question groups not always in correct order

janagombitova commented 7 years ago

As far as I can tell the implementation passes the test plan 👍