Question settings not shown properly after clicking on 'edit' of an existing question

[janagombitova]

When creating a copy of a non-monitored survey (will check monitored surveys later and add a comment) the survey is copied with all the questions, but once the user clicks on a question using 'edit' all the setting for that questions are changed.

I used: UAT1 > 1.9.8 UAT folder > Jana 1.9.8 > Jana 1.9.8 Non MF Surveys > 1.9.8 All questions survey

Steps:

1. Created 1.9.8 All questions survey with all question types and multiple option questions to check how codes work and other settings
2. Copied the survey into the same folder and copied the survey 2nd time into a different folder
3. For both copies, when opening the survey all settings were fine, the preview showed the questions as they were set in the original survey and form, but after opening a question (any as it happened for all questions) by clicking on 'edit' the question name was as in the original survey, but the type was "free text" and all the settings were gone.
4. After changing the question type to "option" the options were showed again as expected

This situation was reproduced for all questions in the copied survey

[janagombitova]

Actually, after checking the original survey I learned, that for already existing questions, once I open them by clicking on 'edit' the settings are changed to 'free text' regardless if it was copied or not. This will cause confusion as the user will think he lost his work and might not remember the question settings.

[janagombitova]

@muloem I checked this issue on UAT, here are the cases and results:

• create a question, save it and then open it again, the issue is gone.
• create a question, save it, not publish the survey, go to the folder, go back to the survey the issue remains (no question properties are shown)
• create a question, save it, hit publish, stay in the survey and open the question again, issue is gone
• publish, go back to the folder, open the survey again and click on 'edit' for a question the issue remains (no question properties are shown)
• copy a published survey and open the copy the issue persists
• copy a not published survey, open the survey, issue persists

So, to conclude, once I move away from the survey and come back to it from a different page, the issue appears, as far as I can tell

(crossed checked on existing instances, all works fine without the issue)

[janagombitova]

Fixed by the rollback of the change that address the blank screen - https://github.com/akvo/akvo-flow/issues/1402 The blank page issue still needs to be addressed, but this issue is not present anymore