The client wrongly includes Google Maps library even if is not going to be used

iperdomo commented 8 years ago

The dashboard supports 3 maps libraries: Google Maps, Mapbox, CartoDB If an instance doesn't define a mapsProvider setting the default is Mapbox, but always include the Google Maps library. The second problem is that this library is using a deprecated version and a missing key parameter.

2016-07-08-172606_1366x768_scrot 2016-07-08-172723_1366x768_scrot

Changes introduced in:

https://github.com/akvo/akvo-flow/commit/0f230d4fccd9f6857e73c95a593188320dda86e1#diff-c093c46f3d3487e360605710095296e4R82

At some point we were using our key for including the library: https://github.com/akvo/akvo-flow/blob/efff25cddc756f3b4e47f5a854c660a582e7afd7/Dashboard/app/dashboard.html#L41

kymni commented 7 years ago

According to the google maps api documentation the <sensor=false> parameter is no longer required to be specified when including the library so I'll be removing it in the issue fix

kymni commented 7 years ago

Test plan

Reload the dashboard and confirm in the developers console that the Google maps library is not loaded unless when specified at deployment
Confirm that warnings in @iperdomo's screen shot no longer appear

janagombitova commented 7 years ago

This is what I see when opening UAT1. I assume we can confirm the implementation is ready for release. @muloem and/or @kymni can you please confirm, I am not 100% sure about this one. Thanks

muloem commented 7 years ago

@janagombitova yep. good to go! 👍

akvo / akvo-flow

The client wrongly includes Google Maps library even if is not going to be used #1732

Test plan