search

akvo / akvo-flow

A data collection and monitoring tool that works anywhere.
http://akvo.org/products/akvoflow/
GNU Affero General Public License v3.0
65 stars 31 forks source link

Replace current phosphate test with Quantofix phosphate #1894

Closed nhternup closed 7 years ago

nhternup commented 7 years ago

The current phosphate test to be replaced with Quantofix phosphate test as it seems to give better results.

More info: https://github.com/akvo/akvo-caddisfly/issues/49

nhternup commented 7 years ago

Tests are defined in tests.json file https://github.com/akvo/akvo-caddisfly/blob/develop/caddisfly-app/app/src/main/assets/tests.json

janagombitova commented 7 years ago

@nhternup does this mean that we will no longer support the current HACH test? Does this change have any implications on current running pilots (even those using the coded question) - do we have anyone using the HACH tests?

nhternup commented 7 years ago

@janagombitova, yes we no longer support the HACH phosphate test. It may be be used by a couple of pilots but we have no confirmation on that. One option is to leave the HACH phosphates in there for a while and remove it later.

valllllll2000 commented 7 years ago

For now both tests are visible after this fix #1915

janagombitova commented 7 years ago

in the latests UAT build there is only one Phosphate test type now, as expected. Can be considered ready to go 👍

janagombitova commented 7 years ago

@nhternup and @muloem I just spoke with Hans and they did not realise they have a pilot using the Phosphate HACH tests. Thus we cannot remove it from the available list of tests. Can we please bring it back on both sides for this release?

I am sorry for the miscommunication about this test type. I just spoke with Hans and he confirmed that the list we will have now, including the phosphate HACH one will be the final list for a few months.

Thanks

nhternup commented 7 years ago

@muloem, The HACH Phosphate has been added back to the tests.json file and can be copied into Flow.

valllllll2000 commented 7 years ago

@muloem I will take care of this

valllllll2000 commented 7 years ago

Test plan:

In dashboards, create a survey, form and group. When creating a question select type caddisfly and make sure both Phosphate tests are displayed.

janagombitova commented 7 years ago

👍 and the test type is back - all good