search

akvo / akvo-flow

A data collection and monitoring tool that works anywhere.
http://akvo.org/products/akvoflow/
GNU Affero General Public License v3.0
65 stars 31 forks source link

Remove geocode from when viewing data #2451

Closed janagombitova closed 4 years ago

janagombitova commented 6 years ago

Context

With this issue: https://github.com/akvo/akvo-flow/issues/2367 we removed geocode from exports. But the geocode still appears in Flow's online workspace when viewing data in the Inspect data tab, Monitoring tab and maps.

Considering this item is no longer part of the data exports, it may confuse Petra or Salim on what this item is and why it is there.

screen shot 2018-01-23 at 16 27 49 screen shot 2018-01-23 at 16 31 04 screen shot 2018-01-24 at 09 40 19

Change

The overall goal of removing geocode was to remove confusion, thus we need to make sure that it also does not show in the online workspace.

stellanl commented 6 years ago

I'm tempted to make a data script that cleans the geocode out of all the responses in the db. That way we do not have to make the UI more complicated by having to filter it out

stellanl commented 6 years ago

Also, if we later add accuracy to the geo answers it will just start to show up in the UI without any code changes. (Reports will have to change again.)

stellanl commented 6 years ago

Of course, running such a cleanup before the app stops submitting geocodes would not be clever.

janagombitova commented 6 years ago

@stellanl Do you mean we also need to make a change in the Flow app? If yes, can you create and explain the issue in the repo?

Kiarii commented 5 years ago

design status: a go

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.