Indicate survey must be selected in Monitoring tab

[janagombitova]

Context

Based on the discussion here: https://github.com/akvo/akvo-flow/issues/2380#issuecomment-360069140 we have agreed to streamline how we show users that they need to select a survey/form before completing an action.

In the Monitoring tab the user must select a survey to be able to see the data points. Currently if she does not select anything and hits 'Find' we show 'No results found'. This error message should apply to when there is no data for a survey and not when a survey is not selected.

Changes

According to the comment linked above:

• highlight the dropdown when the user hits Find but did not select a survey
• ensure that No results found only shows when a survey is selected that is empty, has no data submitted to it

[Maseline]

Test plan Navigate to monitoring tab Select the find option without setting any survey, notice a red border added tothe area around the select field Next, select all the required surveys/form and select Find, notice that results are returned and the red border is removed In another scenario, try selecting only some of the surveys but not all, notice the red border is still added. Select surveys without any forms and then 'Find', notice that in this case No results found is returned.

[bogere]

I had to create a entirely new branch so that work does not conflict with mary 's earlier done work Because I had failed to push my commit changes to the remote branch

[kymni]

For consistency's sake I suggest we consider the approach currently implemented in the data cleaning and reports exports tabs where when the user tries to perform an action without having selected a survey, they get popup prompting them to select one. What do you thing @janagombitova @bogere?

[janagombitova]

@kymni based on the discussion here: https://github.com/akvo/akvo-flow/issues/2380#issuecomment-360069140 we decided to go for an in page approach that should then we reused across the other parts of Flow too

[kymni]

Should we therefore tackle the dropdowns under the data cleaning and exports tabs in this issue or a separate one?

[janagombitova]

That is up to you guys to decide. ;)

[bogere]

@kymni basing on this issue [#2380], they are being handled in separate issues

[bogere]

After discussion with charles, we decided to combine the related issues(#2454 , #2456 and #2380) into a single issue(#2455) Indicate survey must be selected in Monitoring tab #2455

[janagombitova]

@bogere and @kymni I took a quick look and I like how the highlighted box remains until the user gets to the form (or survey for Monitoring tab). But there is something odd in how the drop downs behave (resize) with the highlighted box and without. This is not a showstopper - but needs to be addressed, if not now, in the next iteration.

Furthermore the implementation only works so far on Inspect data and Monitoring. It should be also added to Charts, Exports, Data cleaning.

[janagombitova]

Tested again on glimmer of hope and the above issue with the dropdowns resizing is resolved now. 👍 Well done.

Will Charts, Exports and Data cleaning be handled in another issue?

[kymni]

@janagombitova yes because the code behind exports and data cleaning changed in the recent past