akvo / akvo-flow

A data collection and monitoring tool that works anywhere.

http://akvo.org/products/akvoflow/

GNU Affero General Public License v3.0

65 stars 31 forks source link

Filling a partial Assignment and moving away leads to "Missing required parameters" #3520

Closed iperdomo closed 4 years ago

iperdomo commented 4 years ago

Context

There is no UI to cancel the current editing assignment. If the user moves away to a different tab. We detect that the Assignment has been changed and we attempt to autosave it, leading to a "Missing required parameters" message.

Peek 2020-04-15 07-44

Problem or idea

Attempt to autosave the edits in an Assigment.

Solution or next step

We have an explict Save button. Should we try to autosave the Assignment?

janagombitova commented 4 years ago

Ideally, we should autosave everything in Flow, for each change not just for creating new things (like for editing questions, or cascades) but we do not. If we had autosave, we could remove the save button and do what Lumen does and just show when things are being saved.

How much effort would autosave require?

To keep things consistent with other Flow 'not-so-user-friendly-workflows' when leaving the page, it should mean the changes do not get saved. This is not ideal but it is how other parts of Flow work.

iperdomo commented 4 years ago

How much effort would autosave require?

As you pointed out, we need to make it consistent across the Dashboard, so a "project" itself. Meaning, no trivial. Autosave has come before I mentioned to @muloem that if we want/need autosave, IMHO we also need/want "Undo", meaning a way to rollback what the user did and we saved.

To keep things consistent with other Flow 'not-so-user-friendly-workflows' when leaving the page, it should mean the changes do not get saved. This is not ideal but it is how other parts of Flow work.

It seems this is an old behaviour - https://github.com/akvo/akvo-flow/issues/1223

iperdomo commented 4 years ago

Duplicate of #1223