search

akvo / akvo-flow

A data collection and monitoring tool that works anywhere.
http://akvo.org/products/akvoflow/
GNU Affero General Public License v3.0
65 stars 31 forks source link

Disallow certain characters in survey names #428

Closed mtwestra closed 7 years ago

mtwestra commented 10 years ago

Current situation: All characters are allowed in survey names. This can cause trouble, for example because the survey name is used as the filename in bootstrap files, and a comma in a survey name could cause trouble when receiving the list of surveys from the backend by the device.

Proposed solution: 1) only allow a...z and 1..9 in survey names 2) use the surveyId instead of the survey name in the bootstrap process 3) add the survey name as an attribute to the survey XML file and retrieve it from there.

mtwestra commented 10 years ago

Instead of only allowing a-z and 0-9, we will only disallow "," and "/".

When we move to JSON communication, we can allow these again.

janagombitova commented 7 years ago

@valllllll2000 and @muloem I found this old issue in the backlog where the idea was to disallow "," and "/" . Can we take it up as a follow up from the bug we were fixing around the bootstrap? Or have we made fixes on the backend to make these characters not problematic?

Secondly, when validating the characters can we also ensure that the survey and form name are not empty? https://github.com/akvo/akvo-flow/issues/1324

janagombitova commented 7 years ago

Issue handled with implementation of changes that were released in 1.9.13.1 hotfix The usages of special characters in survey, form and folder names is not a problem anymore