akvo / akvo-lumen

Make sense of your data
https://akvo.org/akvo-lumen
GNU Affero General Public License v3.0
63 stars 18 forks source link

Delete datasets in pending mode #1408

Closed kardan closed 3 years ago

kardan commented 6 years ago

Context

Users end up with datasets that are in pending mode

Problem or idea

There are issues when importing them and they stay in pending mode.

Solution or next step

We need to make sure we don't introduce bugs in a long-running import. Think We can delete in data_source and let the Postgres cascading to its thing to stay safe - maybe.

janagombitova commented 6 years ago

@kardan are you still working on this one or has everything been already handled?

tangrammer commented 6 years ago

@kardan it seems that we can't remove failing imported dataset

screen shot 2018-11-07 at 12 16 27

looking at code detail impls, client library view calls GET /api/library and backend then execute this SQL that returns different "things", the problem arises when we try to delete the dataset based on the id received by client-side, but this id is not a dataset-id anymore

kardan commented 6 years ago

I wonder if this relates to https://github.com/akvo/akvo-lumen/issues/1408

tangrammer commented 5 years ago

do you mean #1449 ? thus #1408 is this one 🤔

tangrammer commented 5 years ago

@kardan @janagombitova are you ok if I start with this issue in the meanwhile i get feedback/review from #1744 ?

tangrammer commented 5 years ago
screen shot 2019-03-05 at 16 27 11

same problem here

in this case DELETE http://t1.lumen.local:3030/api/job_executions/5c7e8f64-4fb2-4b37-906d-4da43760da27 is not even a declared endpoint

kardan commented 5 years ago

@tangrammer I think the DELETE methods are on the different entites (viz, dataset, dashboard). That said, maybe we have nothing for rasters :-(

muloem commented 4 years ago

@tangrammer is this fully resolved? If so maybe we can close it

tangrammer commented 4 years ago

nope

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.