akvo / akvo-lumen

Make sense of your data
https://akvo.org/akvo-lumen
GNU Affero General Public License v3.0
63 stars 18 forks source link

Change data type indication from text to icons #2707

Closed janagombitova closed 3 years ago

janagombitova commented 4 years ago

Context

As part of the work to support RQGs in Lumen we decided to improve the dataset UI. To make the change doable, small and iterative, this issue handles only one small piece of the puzzle and can be addressed and released independently from the other changes.

Why do we have this issue? What are we trying to solve? 

To simplify to UI and clean it up a bit, easily distinguish between a standard element and a data value.

How will this benefit the users & Akvo?

Plus as this change is part of a larger UI improvement of the dataset editor to support RQGs so we can assume that the entire change will:

Opportunity 

Current status quo

These are indicated as text next to the column header.

Screen Shot 2020-05-27 at 14 43 09

The idea 

The idea is to change all datatypes to icons. On mouseover, the data type should be shown. On clicking on the type icon, the user should have the option to change the data type, as it works today.

Screen Shot 2020-05-27 at 13 07 45 2

Next steps 


janagombitova commented 4 years ago

Just to update the current status: We have these datatypes now:

Kiarii commented 3 years ago

@janagombitova aren't Option and Multiple are Text data types?

janagombitova commented 3 years ago

@Kiarii In theory they are, but in practice they are not.

They are automatically given to Flow option questions, geoshapes and Caddisfly and specific transformations only work for them and visualizations behave differently with them.

So they need to be shown as Option and Multiple so Salim sees why Lumen behaves differently with these columns.

Kiarii commented 3 years ago

I see, but arent they handled as Text when it comes to the types of transformations and aggregations they comply to?

janagombitova commented 3 years ago

@Kiarii they are not actually.

MULTIPLE is applied to Flow Caddisfly and geoshape questions. With this data type, these columns are selectable for the extract multiple values transformation. No other data types are selectable here. This is because the MULTIPLE data types hold more than one value and Lumen knows how to process them with the transformation.

OPTION - here the difference is how visualisations behave. They look like TEXT but in the case of OPTION Lumen does not look at unique values per cell when drawing the visualisation, but looks are variables and groups them automatically making it easy to analyse multiple answer option questions.

Also, MULTIPLE and OPTION can be changed to other data types but not other way around

janagombitova commented 3 years ago

When testing with Chrome in a private browser the icons did not show

Screen Shot 2020-10-15 at 19 49 19
Kiarii commented 3 years ago

and the mousetooltip for the 'code' data type is "Multiple values"..

janagombitova commented 3 years ago

Resolved. Tested. Released.