search

akvo / akvo-lumen

Make sense of your data
https://akvo.org/akvo-lumen
GNU Affero General Public License v3.0
63 stars 18 forks source link

Importing new datasets does not recognise repeated groups #2748

Closed janagombitova closed 3 years ago

janagombitova commented 4 years ago

When testing today on dark-demo, I noticed that a new dataset that I import from Flow does not recognise that there is a repeated group in it. Existing datasets, that I used the days before are fine. I am not sure if this is a new issue introduced today or it was here longer.

Example 1

Example 2

I also noticed that when looking at the datasets in the Library, they do not indicate the origin from Flow. Could this be the problem? But then they do show the group navigation, so Lumen knows it is from Flow as with non-Flow datasets we do not show the data group navigation.

iperdomo commented 4 years ago

I noticed that a new dataset that I import from Flow does not recognise that there is a repeated group in it.

@janagombitova what do you mean by does not recognise ?

We removed the current implementation of RQG, the one that places everything in one cell, as per PR: https://github.com/akvo/akvo-lumen/pull/2733

In the comments I asked about the existing imported datasets: https://github.com/akvo/akvo-lumen/pull/2733#issuecomment-648938109 https://github.com/akvo/akvo-lumen/pull/2733#issuecomment-649254485

@tangrammer said that he was going to delete those: https://github.com/akvo/akvo-lumen/pull/2733#issuecomment-648946798

janagombitova commented 4 years ago

I see. We still need to handle the imported datasets then. As it is only us, who made those - perhaps just delete the datasets fully? Or what was the idea?

My following question is, why does the UI not mark the groups as repeated with the icon?

iperdomo commented 4 years ago

I see. So then the following question is, why does the UI not mark the groups as repeated with the icon?

I think because the client doesn't know that is repeated. I'm checking if the metadata about the group is there.

janagombitova commented 4 years ago

Thank you!