search

akvo / akvo-lumen

Make sense of your data
https://akvo.org/akvo-lumen
GNU Affero General Public License v3.0
63 stars 18 forks source link

Add data-group support to update dataset logic #3084

Closed tangrammer closed 3 years ago

tangrammer commented 3 years ago

Add test flow uat1/_ _Lumen tests/Lumen Testing/2 Lumen RQG Testing/New form

(tu/read-edn-flow-dataset "uat1" "638889127" "638879132")

Screenshot 2021-01-07 at 12 54 14

tangrammer commented 3 years ago

Changes looks fine to me. But, while running all project test via cider I got errors with the test-data-groups-transformations test. Not sure if this was related or whatnot.

akvo.lumen.lib.transformation-test 1 non-passing tests:

Fail in test-data-groups-transformations Valid log

expected: ({:rnum 1, :c1 "A ", :c2 "b ", :c3 "c"})

actual: ({:rnum 1, :c1 "a ", :c2 "b ", :c3 "c"}) diff: - [{:c1 "A "}]

  • [{:c1 "a "}]

@kardan can you try again pulling last commit https://github.com/akvo/akvo-lumen/pull/3084/commits/b28e9026a0125ca278eddbf8297e223551f9fe7e ?

kardan commented 3 years ago

Tested again and all worked fine.