akvo / akvo-lumen

Make sense of your data

https://akvo.org/akvo-lumen

GNU Affero General Public License v3.0

63 stars 18 forks source link

Capitalized group names affects to derive-js transformation #3092

Closed tangrammer closed 3 years ago

tangrammer commented 3 years ago

Context

right now we capitalize group names by default in dataset view data-group Screenshot 2021-01-12 at 10 52 44

Problem or idea

trying js transformation row["Non repeatable"]["Family name"]+" welcome" FAILS but row["Non Repeatable"]["Family name"]+" welcome" SUCCEED

Screenshot 2021-01-12 at 10 53 51

Solution or next step

How could we solve it?

tangrammer commented 3 years ago

@janagombitova @kardan should we adapt the backend to be case insensitive or just don't change letter case in frontend

PS: changing behaviour in client is just removing css class, backend changes should have more changes and tests and perhaps more unknown consequences (thinking in undo with existent datasets with 2 groups having different letter case)

tangrammer commented 3 years ago

Relates https://github.com/akvo/akvo-lumen/blob/de85cd70ad8dcd2c60e9de97d00f479ace9a4806/client/src/components/dataset/sidebars/GroupsList.scss#L21

janagombitova commented 3 years ago

@tangrammer I would say we show things are they are. So do not change letter case in the frontend. It is less work and the users see the data, titles, etc as it is put in.

kardan commented 3 years ago

Agree

tangrammer commented 3 years ago

finally we need to adapt "Metadata", "Main" and "Transformations" in backend side thus I don't think we want to show these values in lower case 🤔

janagombitova commented 3 years ago

Agree.