search

akvo / akvo-lumen

Make sense of your data
https://akvo.org/akvo-lumen
GNU Affero General Public License v3.0
63 stars 18 forks source link

Add indication that a column comes from a transformation #3140

Closed janagombitova closed 3 years ago

janagombitova commented 3 years ago

With the data groups flag, we have introduced also some visual changes to the dataset. We moved all transformed column from the separate Transformed group to their parent group. With this change, we need to visually show the user where the new column went and which one it is.

We agreed to add an icon to these columns: https://github.com/akvo/akvo-lumen/issues/2740#issuecomment-654142724 I tried on a partner dataset and noticed that the icon only shows for Derive JS columns. But not for all new columns that are created from any transformation. I assume this happened as a misunderstanding as we called the columns Derived columns. But my understanding was that any new column generated from a transformation should have that icon, so Salim knows this is a new column and not from the original dataset (as imported).

Secondly, would it be possible to bring the user to the column after the transformation is done? So could we automagically scroll the user to the column?

janagombitova commented 3 years ago

My bad. I did a bit more testing on lumen.akvotest.org and saw that the columns are indicated properly. Issue has been handled