akvo / akvo-notifications

Turns business events into user notifications
GNU Affero General Public License v3.0
1 stars 1 forks source link

[#1] First cut on an alpha prototype #2

Closed kardan closed 10 years ago

kardan commented 10 years ago
iperdomo commented 10 years ago

As discussed in our conversation:

kardan commented 10 years ago

Updated "feature/1-setup" after review.

kardan commented 10 years ago

Honestly I don't think it is "pernickety", it's the services' interface (ok, maybe a bit - but it's still important ;-) ). I initially added slashes while I was investigating how strict Liberator was with them and forgot to remove them. So I'm in the non trailing slash religion, but got caught slashing...

I don't think it's a matter of being pedant with URLs, but more about preference. One could just as well argue that /services returns "a" resource that list the services. And that the slashes represent the hierarchy up to that resource. It's more common with APIs, but even blogs sometimes use of non trailing slashes on a category list.

iperdomo commented 10 years ago

:+1: code reviewed + correct