[#378] Fix Legend MainMap not appearing in FE - Githubissues

akvo / wai-sdg-portal

Wash Dataportal for WAI SDG

GNU Affero General Public License v3.0

1 stars 4 forks source link

[#378] Fix Legend MainMap not appearing in FE #379

Closed ifirmawan closed 1 year ago

ifirmawan commented 1 year ago

TODO/DONE

[x] Fix Legend MainMap not appearing in FE
[x] Change question id not found with water service level as shape

Changes log

Front-end MainMap

Remove conditional scoreOptions?.length because not all types of maps have JMP scores.
In order to handle scoreOptions we just add it separately and find markerOptions that don't have an option.
Check form switching by checking loadedFormId and current.formId are the same or not
Add (!_.isEqual(opts1, opts2)) to avoid memory leak

Joy's Request

Add map indicator - WAI Ethiopia

[x] Waterpoint : Water Source Type , Functionality Status
[x] CLTS : Open Defecation Status, Implementing Partner

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1204966631935606