akxcv / vuera

:eyes: Vue in React, React in Vue. Seamless integration of the two. :dancers:
MIT License
4.3k stars 242 forks source link

Don't pass `children` to React component if not present #163

Open thany opened 1 year ago

thany commented 1 year ago

Consider this React component called in a Vue template:

<hello-from-react />

Couldn't be simpler. But it passes children which aren't there at all. Using forbidExtraProps from airbnb-prop-types it fails prop-type validation.

Please ONLY pass children if a component has content, a <slot>, or an explicit children prop.

Same problem occurs in that other superfluous prop.