search

akxcv / vuera

:eyes: Vue in React, React in Vue. Seamless integration of the two. :dancers:
MIT License
4.3k stars 242 forks source link

Distribution file compatibility #29

Open phillbaker opened 6 years ago

phillbaker commented 6 years ago

This issue came up because of IE11, but I totally understand if including support for IE11 is not something within the scope of this library. It looks like es2015 compatibility is desired based on the .babelrc:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/.babelrc#L6

However, both Object.assign and Object.entries appear in the built common js file:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L229

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L451

I always forget which level Object.assigns is at, but I believe Object.entries is much more recent? Is this maybe a bug in the rollup or babel configuration during the build?

Thanks!

akxcv commented 6 years ago

Hi, yeah, both Object.assign and Object.entries are not supported by IE. Hmm, looks like we need to replace those methods with more IE-compatible code. For now, using polyfills is the only option.