Comments

[akzhy]

Optionally add disqus by providing the value in siteMetadata

[akzhy]

Feel free to share any recommendations you have @ahmad-reza619,

[ahmad-reza619]

Feel free to share any recommendations you have @ahmad-reza619,

will do, i'm glad to help. 😄

[ahmad-reza619]

how about we add some test too? so that it will guarantee our template stay safe and sound 😃

[ahmad-reza619]

hey @akzhy i've added some optimization. anyway, gatsby complains about disqus option that is not present in gatsby-config.js file. could we add some initial values for it?

[akzhy]

Hey @ahmad-reza619 is it a warning? If so where does it appear? There are no errors/warnings on my device

[ahmad-reza619]

it's an error unfortunately, it looks like this

[ahmad-reza619]

and why did you use yarn, when you used npm before? there is 2 lock file now, and from my experience this could cause issues

[akzhy]

Can you try clearing the cache ? gatsby clean. For the lockfile part, I switched to yarn a couple of months ago 😅, forgot I used npm for this one. @ahmad-reza619

[ahmad-reza619]

so, which one are we going to use?

[akzhy]

Yarn is pretty good

[akzhy]

Did clearing the cache work ? @ahmad-reza619

[ahmad-reza619]

nope, i was using node 8.6 so i tried to switch to node 13, but errors still happen, so now i tried with yarn

[ahmad-reza619]

all right it works on yarn with node v13

[akzhy]

Okay great we can proceed with yarn

[ahmad-reza619]

i've removed npm lock file so we should be good for now. and maybe we'll mention to use node v13 in readme perhaps?

[ahmad-reza619]

and let's not forget to mention about disqus in readme

[akzhy]

Yeah we will need to update the readme to inform about disqus

[akzhy]

Okay, looks good to me