Added cookie consent and other fixes

akzhy / gatsby-starter-elemental

Gatsby starter for portfolio sites

https://elemental.netlify.app

MIT License

137 stars 57 forks source link

Added cookie consent and other fixes #20

Closed marcphilippebeaujean-abertay closed 4 years ago

marcphilippebeaujean-abertay commented 4 years ago

Added cookie banner
Fixed crash on changing window size because "this" was not set correctly
Fixed social media icons on the contact form not having the same hover effect than the ones on the sidebar

akzhy commented 4 years ago

Hey @marcphilippebeaujean-abertay , sorry for the delay in responding. I am a bit busy for a couple of days, so I can't take a look at it now. I will reach back to you as soon as I am free.

ahmad-reza619 commented 4 years ago

Hi @marcphilippebeaujean-abertay thank you for your PR, and we're sorry for being late. I have viewed your code. It's good, but giving cookie consent at top of the page kinda intrude the content. imo usually cookie consent is placed at bottom of page. and also the link to data policy is broken? or is it just doesn't exist yet?

marcphilippebeaujean-abertay commented 4 years ago

Hi, thanks for getting back to me. Cookie consent is on top of the page for many due to legal reasons, but I can see it making sense on the bottom as well. Sorry if that link is broken, I might have changed it! My bad.

ahmad-reza619 commented 4 years ago

well, imo cookie consent inside heading / navigation seems strange

akzhy commented 4 years ago

Added in #31