[BUG] - PDF generation issue in Mozilla Firefox

al1abb commented 1 year ago

Description

[!NOTE] These issues also arise in the deployed version of the app

Direct Download: After generating a PDF, the file is downloaded directly without proper user interaction.
Empty PDF iframe: The PDF iframe appears to be empty, causing difficulties in rendering or displaying the generated PDF.
Opening in New Tab: Opening the PDF in a new tab does not work as expected; it may not load or display correctly.
Quantity Input Error: The quantity input field can accept non-numeric values even though it is specified as type=number.
Signature Drawing: The signature drawing on canvas feels slower and lags behind the mouse (this issue comes from shadcn dialog element).

Expected Behavior:

PDF should not be downloaded right after generation. Iframe content should be visible.
PDF should be shown in a new tab when opened in a new tab.
Quantity and some other numeric input fields should only accept numbers.
Signature drawing should be smooth with no lag

Environment:

kishaningithub commented 6 months ago

Any pupeteer alternatives that can fix this natively?

al1abb commented 6 months ago

Any pupeteer alternatives that can fix this natively?

Don't know

kishaningithub commented 6 months ago

I have used the following in the past

It has a declarative way to generate PDF within the browser itself..

al1abb commented 6 months ago

I have used the following in the past

https://github.com/diegomura/react-pdf

It has a declarative way to generate PDF within the browser itself..

I know about it. Tried using it in the past, but had issues configuring it with next.js. Then I decided to use puppeteer instead

kishaningithub commented 6 months ago

Oh okie.. then can https://github.com/foliojs/pdfkit be directly used?

al1abb commented 6 months ago

Oh okie.. then can https://github.com/foliojs/pdfkit be directly used?

Not sure

Qodestackr commented 6 months ago

This is a great project but just having issues extracting it to fit my context. Thanks tho

Faizanahmedsy commented 4 months ago

It is not working on other broweser too