alRex-U / ParCool

A Minecraft Forge Mod for action of Cool Parkour
GNU General Public License v3.0
42 stars 30 forks source link

Infinite Stamina config does not work #159

Closed aaronhowser1 closed 1 year ago

aaronhowser1 commented 1 year ago

Summary

[Stamina]
    #Limitation of max stamina
    #Range: 300 ~ 100000
    max_value_of_stamina = 10000
    #Limitation of max stamina recovery
    #Range: 1 ~ 10000
    max_value_of_stamina_recovery = 1000
    #Allow Infinite Stamina
    infinite_stamina = true

and yet I use up stamina when doing parkour

Running Environment

alRex-U commented 1 year ago

Did you enable infinite stamina on client side?

aaronhowser1 commented 1 year ago

Is it on both sides? Shouldn't it just be server side? Regardless, this was in parcool-server.toml, and is in fact the default value.

alRex-U commented 1 year ago

If you want to enable infinite stamina, you have to enable it on both client and server side.

aaronhowser1 commented 1 year ago

Doesn't that seem a bit off? Why is that?

On Fri, Apr 21, 2023, 9:33 PM alRex-U @.***> wrote:

If you want to enable infinite stamina, you have to enable it on both client and server side.

— Reply to this email directly, view it on GitHub https://github.com/alRex-U/ParCool/issues/159#issuecomment-1518477553, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXYWITN5B6I6HCHSGYVHNLXCM7PLANCNFSM6AAAAAAXCCOY5Y . You are receiving this because you authored the thread.Message ID: @.***>

alRex-U commented 1 year ago

have to enable it on both client and server side

was not a proper expression. More exactly writing,

Players can enable infinite stamina whenever they want to, but also hosts of the servers can disable it forcibly"

is correct. (Thus the permission of infinite stamina on server side is defaultly true, as you can see)

Anyway the problem is whether program is working as I think. Can you enable infinite stamina.

aaronhowser1 commented 1 year ago

That did indeed work. Maybe a line should be added to the serverconfig's comment like Also has to be enabled in client config? I would never have thought to look in the client config for something that changes behavior.

alRex-U commented 1 year ago

This config is just a permission. I think players can understand it by reading the word "Allow" in the description. Well, indeed I should write more detailed description.

At least this is not a bug so please let me close this issue.

Thanks for your suggestion.