search

alRex-U / ParCool

A Minecraft Forge Mod for action of Cool Parkour
GNU General Public License v3.0
41 stars 30 forks source link

[~] Subtitle fixes + custom hitboxes/poses #259

Closed crispytwig closed 1 month ago

crispytwig commented 1 month ago

Good afternoon.

Throughout playing with your mod (as well as looking through some of the issue reports), I noticed some small issues.

  1. Rolling and dodging did not change the Player's hitbox -- the entire point of which should be to, well, dodge things like attacks or arrows. When playing, I could not do this because the hitbox stays 2 blocks tall. I fixed this so it now shrinks to the same size as the "SWIMMING" Pose, 0.6F x 0.6F.
  2. Leading off from the hitbox issue, some of the animations used the "SWIMMING" Pose. I have incorporated custom ParCool poses that may be used in the PlayerMixin to give the Player custom hitbox changes when using actions from the mod.
  3. There were no subtitle lang entries for the sounds of the actions -- I've added these as well as reorganized and better alphabetized the base en_us.json file.
  4. Understandably as your main language is (assumingly as I have found Japanese entries) not English, I have changed "Fast Run" to "Dash", a more proper English translation. Feel free to remove this if you'd like, but every related file should be properly changed!

Please consider merging this with the main branch -- it'll take some of the effort off of your hands and add some (what I believe to be) quality features that really enhance the mod in smaller ways.

I love this mod, keep up the good work! ♥

sinnamoff commented 1 month ago

<3

noodlescript commented 1 month ago

a heart or something

alRex-U commented 1 month ago

Thanks for your work.

However I cannot accept this changes.

  1. Please send pull requests for each changes. It is better to divide hitbox fixing changes and others problems
  2. The word Dash is used internally as explicitly different meaning to Fast Run so I didn't want you to change without any dicussion. Actually this change may be more natural but please let me know before you do
  3. Did you change entries written by PascalCase in translation files to snake_case? In translation, they are intentionally written as so. The mod auto-generate the entry names with reflection to read their values. so don't changes them

I appreciate your contributions. If possible, could you open issues for each suggestions? I think I can give a better answer.

crispytwig commented 1 month ago

Thanks for your work.

However I cannot accept this changes.

  1. Please send pull requests for each changes. It is better to divide hitbox fixing changes and others problems
  2. The word Dash is used internally as explicitly different meaning to Fast Run so I didn't want you to change without any dicussion. Actually this change may be more natural but please let me know before you do
  3. Did you change entries written by PascalCase in translation files to snake_case? In translation, they are intentionally written as so. The mod auto-generate the entry names with reflection to read their values. so don't changes them

I appreciate your contributions. If possible, could you open issues for each suggestions? I think I can give a better answer.

I've split the hitboxes into their own pull request at https://github.com/alRex-U/ParCool/pull/260 .