search

alacarte-maps / alacarte

Renderer for OpenStreetMap tiles.
https://alacarte-maps.github.io/
Other
58 stars 18 forks source link

Revert "Fixed boost static library problem" #111

Closed Scheirle closed 6 years ago

Scheirle commented 6 years ago

This reverts commit 86edb188fcdef4a21733cfb41a57734a01a9d4c3.

Commit 86edb18 - "Fixed boost static library problem" introduces duplicated code.

  1. Line 19-21 are already covered by Line 24-29
  2. Line 87 duplicate of Line 100
  3. Line 86 should not be needed as it does the same as Line 87/100.

We may need to pull Line 100 (add_definitions(-D_WIN32_WINNT=0x0601)) further up.

florianjacob commented 6 years ago

@SrTobi do you happen to remember how you wanted it to turn out back then?

SrTobi commented 6 years ago

Why would we want to pull line 100 further up?

Scheirle commented 6 years ago

Why would we want to pull line 100 further up?

I just wasn't sure if it was required or not.

SrTobi commented 6 years ago

If I remember correctly the windows implementation of socket.h demands that you specify this definition to acknowledge some kind of api change, they made in the past. boost::asio uses socket.h, if I'm not mistaken. So, yeah, it's required

florianjacob commented 6 years ago

Thanks!